|
Thread: ERA II - Source code - Help and discussion | This thread is pages long: 1 2 3 4 5 6 7 8 9 10 11 · «PREV / NEXT» |
|
gamemaster
Adventuring Hero
|
posted April 06, 2020 08:32 PM |
|
|
@majaczek
I see that you used long version of HE:X. Now it work with post 2.9.12 version (and this port).
Still need Bersy to confirm is new behavior is intentional or accidental.
Also with new version of knightmare i got message:
"gui_tricks.era
Unrecognized HD_WoG.dll version
OK"
I use HD version 5000205 5.0 RC53
Is that something i need
latest ported version dll if someone have time for test
https://dropmefiles.com/9OBR0
|
|
majaczek
Supreme Hero
Work at Magic Dimmension
|
posted April 06, 2020 09:58 PM |
|
Edited by majaczek at 23:28, 06 Apr 2020.
|
gui_tricks.era only fixes some gui from HD_wog.dll nothing really important. currently only work with newest HD-mod. I may add support for the one you use later
edit:
crash with era preview dlls
also text glitches ...
also broken WoG options:
|
|
gamemaster
Adventuring Hero
|
posted April 06, 2020 11:44 PM |
|
|
i will investigate crash tomorrow.
Regarding options glitch. I reproduce it in latest version. But 2.9.12 port work ok. So i am afraid that it is introduced after 2.9.12.
This one also need Bersy attention.
|
|
Bersy
Honorable
Supreme Hero
|
posted April 07, 2020 01:03 AM |
|
|
Quote: @Bersy
In last github version there are two redundant functions:
I know, not a problem.
Quote: Hi Bersy
Hi gamemaster
Would you please tell me what the following code does and how it work?
Core.p.WriteDataPatch(Ptr($74C1AE + 2), ['%d', @@AdditionalCmds[0].Handler]); // Patched command
ERM_Additions list was extended/relocated. I patch reference to it, because now plugins can extend ERM receivers (RegisterErmReceiver function), which is used in 2 dlls by gamecreator, included in ERA (pandora API + seer huts).
this line for example
!!HE117:X6/104/104/277;
Quote: when it works (2.9.12 version), SpecRecord.Setup look like this
(6, 104, 0, 0, 0, 104, 277)
but it is now
(6, 104, 104, 277, 0, 0, 0)
Not sure what is SpecRecord.Setup structure. Is that related to two versions of HE:X6 command
Anyway if Erm.Hook_HE_X is disabled all work well
Thank you, I will investigate it. Tried to rewrite function in a simple form, but it seems, that it should be complicated for compatibility reasons.
-----------------------
I don't reproduce options glitch. What should I do?
____________
Heroes 3 Era and everything for it. Releases folder for releases.
|
|
majaczek
Supreme Hero
Work at Magic Dimmension
|
posted April 07, 2020 03:56 PM |
|
Edited by majaczek at 17:43, 07 Apr 2020.
|
|
gamemaster
Adventuring Hero
|
posted April 07, 2020 05:33 PM |
|
|
@Bersy
regarding options glitch:
Just compile dll from latest version on github.
Then go to options.
You will see that some tabs has items under buttons like majaczek posted.
In my case problematic is 4th tab. After clicking on 4th tab and go to 1st game crash.
I tried that with 2.9.12 and all work ok.
@majaczek
Man, is that 40" monitor?
I take quick look. Error is located in HeroMakeStep function.
So it is odd location for new era bug. But we will see...
I confirm above error on same place as you mentioned.
Error is presented before and after 2.9.12 version.
Also confirm that enter into boat make problem.
|
|
majaczek
Supreme Hero
Work at Magic Dimmension
|
posted April 07, 2020 07:38 PM |
|
|
sorry, boat problem was mine.
updated emerald3_3
|
|
gamemaster
Adventuring Hero
|
posted April 07, 2020 08:02 PM |
|
|
yup
Now it work
|
|
majaczek
Supreme Hero
Work at Magic Dimmension
|
posted April 07, 2020 08:25 PM |
|
|
debug
It crashed when clicked on town garison
|
|
gamemaster
Adventuring Hero
|
posted April 07, 2020 08:41 PM |
|
|
Can you confirm that error exist without KK.
With KK i can sometimes reproduce error, but without it there is no error.
|
|
majaczek
Supreme Hero
Work at Magic Dimmension
|
posted April 07, 2020 08:54 PM |
|
Edited by majaczek at 21:27, 07 Apr 2020.
|
gamemaster said: Can you confirm that error exist without KK.
With KK i can sometimes reproduce error, but without it there is no error.
it is when moving experienced units to garrison, and with clean ERA it doesn't happen
EDIT: Please Help ?
|
|
gamemaster
Adventuring Hero
|
posted April 07, 2020 10:16 PM |
|
|
hahaha
I'm not a doctor but I'll take a look
EDIT:
Still nothing. Tomorrow after work will try again.
|
|
majaczek
Supreme Hero
Work at Magic Dimmension
|
posted April 08, 2020 12:23 AM |
|
|
gamemaster said: hahaha
I'm not a doctor but I'll take a look
EDIT:
Still nothing. Tomorrow after work will try again.
very thanks
|
|
gamemaster
Adventuring Hero
|
posted April 08, 2020 10:23 PM |
|
|
I located problem.
Some amethyst stuff patch bytes at $0071943C.
One instance is in "amethyst_fix3_.bin", another two are in "amethyst2_4.dll".
Anyway it should be "shl eax, 4" instead of patched:
What that code do ?
Is that some wild loose patch or it is intentional?
Anything "shl 15" look odd
I am still not sure how to reproduce bug in 100% cases. Seems that happens randomly.
|
|
majaczek
Supreme Hero
Work at Magic Dimmension
|
posted April 09, 2020 11:35 AM |
|
Edited by majaczek at 19:03, 09 Apr 2020.
|
mistake :P
it should replace
shl eax, 0x05
with shl eax, 0x16
it replaces two fields in experience structure
one is old creature number (size 8 bits) with unused one (10 bits)
or maybe not mistake
Quote:
replace_byte the_bytes2[]={
{ 0x00726512, 0x04 },
{ 0x0071acdf, 0x04 },
{ 0x0071b611, 0x04 },
{ 0x00726a01, 0x04 },
{ 0x0071b555, 0x04 },
{ 0x004b4f13, 0x04 }, // not sure
{ 0x0053f347, 0x03 }, // not sure
{ 0x0053f33e, 0x03 }, // not sure
{ 0x0071a9db, 0x04 },
{ 0x00719945, 0x15 },
{ 0x00719a07, 0x15 },
{ 0x00703da7, 0x60 }, //pushad
{ 0x00703da8, 0xb8 }, //mov eax, next_four_bytes
//------------------
{ 0x00703dad, 0xFF }, { 0x00703dae, 0xD0 }, //call eax
{ 0x00703daf, 0x90 },
{ 0x00703db0, 0x90 },
{ 0x00703db1, 0x90 },
{ 0x00703db2, 0x90 },
{ 0x00703db3, 0x90 },
{ 0x00703db4, 0x90 },
{ 0x00703db5, 0x61 }, //popad
{ 0x0, 0x0 } // stop_mark
};
do it have any sense ?
EDIT: changes done to this struct
Quote: struct {
unsigned Act : 1; // ĺńňü/íĺň
#define CE_HERO 1
#define CE_MAP 2
#define CE_TOWN 3
#define CE_MINE 4
#define CE_HORN 5
unsigned Type : 4; // ňčď - ăäĺ őđŕíčňń˙
unsigned MType : 8; // ňčď ńóůĺńňâ
unsigned mHasArt : 1; // has art
unsigned mArt : 2; // up to 4 arts
unsigned mCopyArt: 2; // up to 4 copy
unsigned mSubArt : 4; // up to 16 sub art
unsigned _un : 10; // reserve
// unsigned _un : 19;
} Fl;
EDIT: XXL maps are buggy (probably also due to emerald) so it cannot be loaded if saved with open full adventure map
EDIT: XXL maps are buggy in same way without KK so it's not entirely emerald cause
|
|
gamemaster
Adventuring Hero
|
posted April 09, 2020 08:57 PM |
|
|
Quote: do it have any sense ?
nop
For now i have not enough information to figure out situation.
Dont know what code around problem do, and dont know what code around patches do. So i am in total darkness
All i know that eax from problematic location is used as index.
If it has value $2D (originally) it will be shifted by $4 to $2D0.
If it is shifted by $15 it would be $5A00000. With that we get memory out of our scope ($5A00000+$860558).
Quote: EDIT: XXL maps are buggy (probably also due to emerald) so it cannot be loaded if saved with open full adventure map
EDIT: XXL maps are buggy in same way without KK so it's not entirely emerald cause
How to reproduce it?
I made quick test and there is no problem. But maybe i miss something.
|
|
majaczek
Supreme Hero
Work at Magic Dimmension
|
posted April 09, 2020 09:06 PM |
|
|
gamemaster said:
Quote: EDIT: XXL maps are buggy (probably also due to emerald) so it cannot be loaded if saved with open full adventure map
EDIT: XXL maps are buggy in same way without KK so it's not entirely emerald cause
How to reproduce it?
I made quick test and there is no problem. But maybe i miss something.
well it not always crashes but 75% when loading game and 25% when saving game IF whole map is revealed (every single tile)
you may try the Open Map Script from ERA Scripts or custom_cheats.era from my set of plugins
|
|
gamemaster
Adventuring Hero
|
posted April 09, 2020 09:57 PM |
|
|
Confirmed for random XXL map.
Error on load. Not on save.
In ported and regular 2.9.12 version without KK mod.
|
|
Bersy
Honorable
Supreme Hero
|
posted April 11, 2020 03:19 AM |
|
|
|
majaczek
Supreme Hero
Work at Magic Dimmension
|
posted April 11, 2020 11:27 AM |
|
|
yes but only in XXL when loading save
|
|
|